[BE] 체크리스트 업데이트 시 지하철 역도 변경되도록 수정한다 #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JINU-CHANG
requested changes
Oct 24, 2024
| @Query("UPDATE ChecklistStation cs " + | ||
| "SET cs.deleted = true " + | ||
| "WHERE cs.checklist.id = :checklistId") | ||
| void deleteAllByChecklistId(Long checklistId); |
There was a problem hiding this comment.
@param 붙여주세용 ㅠㅠ 자꾸 터져요 ..
| @@ -157,6 +157,15 @@ public static ChecklistRequest CHECKLIST_UPDATE_REQUEST() { | |||
| ); | |||
| } | |||
|
|
|||
| public static ChecklistRequestV1 CHECKLIST_UPDATE_REQUEST_V1() { | |||
| return new ChecklistRequestV1( | |||
| RoomFixture.ROOM_UPDATE_REQUEST(), List.of(1, 2, 3, 4), | |||
There was a problem hiding this comment.
Suggested change
| RoomFixture.ROOM_UPDATE_REQUEST(), List.of(1, 2, 3, 4), | |
| RoomFixture.ROOM_UPDATE_REQUEST(), List.of(Option.BED.getId(), Option.INDUCTION.getId() ... ), |
| @@ -63,4 +64,19 @@ void findByChecklistId_noData_exception() { | |||
| assertThat(checklistStationRepository.findByChecklist(checklist)) | |||
| .isEmpty(); | |||
| } | |||
|
|
|||
| @DisplayName("체크리스트 아이디를 통한 삭제 성공") | |||
There was a problem hiding this comment.
DisplayName에 지하철에 대한 내용이 포함되면 좋겠어요!
There was a problem hiding this comment.
ChecklistStationRepositoryTest라 저는 포함하지 않아도 괜찮을 것 같아요!
There was a problem hiding this comment.
일단 안붙이는 방향으로 가보겠습니다!
shin-jisong
approved these changes
Oct 24, 2024
| @@ -63,4 +64,19 @@ void findByChecklistId_noData_exception() { | |||
| assertThat(checklistStationRepository.findByChecklist(checklist)) | |||
| .isEmpty(); | |||
| } | |||
|
|
|||
| @DisplayName("체크리스트 아이디를 통한 삭제 성공") | |||
There was a problem hiding this comment.
ChecklistStationRepositoryTest라 저는 포함하지 않아도 괜찮을 것 같아요!
JINU-CHANG
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
지하철 역 업데이트 오류 수정
📢 논의하고 싶은 내용
🎸 기타